[FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack
derek.buitenhuis at gmail.com
Thu Aug 25 17:25:56 EEST 2016
On 8/24/2016 10:54 PM, Michael Niedermayer wrote:
> IIRC the removed code tried to detect a reorder delay that is not
> possible in a valid file due to the profile constraints. Aka dts and
> pts are too far appart for the largest amount of buffers allowed in
> any codec.
Basing this on timestamps after applying an edit list shift doesn't
seem right at all. Maybe edts support didn't exist when it was added?
> Quite possibly this limit or the check itself have become wrong
> over time ...
> Its even possible there has been some misunderstanding in the buffer
> cts/pts/dts limitations.
> patch probably ok
> iam a bit unsure about "st->codecpar->video_delay = 1;" though
This was added at the same time, yes. It also looks wrong to me,
but I was not entirely sure. Do you think I should remove it?
More information about the ffmpeg-devel