[FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

Michael Niedermayer michael at niedermayer.cc
Thu Aug 25 17:40:45 EEST 2016

On Thu, Aug 25, 2016 at 03:25:56PM +0100, Derek Buitenhuis wrote:
> On 8/24/2016 10:54 PM, Michael Niedermayer wrote:
> > IIRC the removed code tried to detect a reorder delay that is not
> > possible in a valid file due to the profile constraints. Aka dts and
> > pts are too far appart for the largest amount of buffers allowed in
> > any codec.
> Basing this on timestamps after applying an edit list shift doesn't
> seem right at all. Maybe edts support didn't exist when it was added?

it seems code from around teh time contained only code to skip
over the edit list data and print a warning but didnt use it at all

> > Quite possibly this limit or the check itself have become wrong
> > over time ...
> > Its even possible there has been some misunderstanding in the buffer
> > cts/pts/dts limitations.
> > 
> > patch probably ok
> [...]
> > iam a bit unsure about "st->codecpar->video_delay = 1;" though
> This was added at the same time, yes. It also looks wrong to me,
> but I was not entirely sure. Do you think I should remove it?

i honestly dont know
but its probably best to remove in a seperate patch so if it breaks
something bisect would immedeatly point to which of the 2 changes
caused it

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160825/fbf77640/attachment.sig>

More information about the ffmpeg-devel mailing list