[FFmpeg-devel] [PATCH 07/21] libavcodec/metaenc: added an encoder/decoder for timed metadata

Erkki Seppälä erkki.seppala.ext at nokia.com
Thu Aug 25 18:58:41 EEST 2016


On 08/23/2016 05:46 PM, Michael Niedermayer wrote:
> this breaks fate
> make distclean ; ./configure && make -j12 fate
> deadlocks and never finishes

Well that was embarrassing, thanks for pointing it out.

The issue was that I had introduced metacodec_class that was shared 
between ff_meta_encoder and ff_meta_decoder, and due to this sharing 
av_opt_child_class_next was never able to get pass them as it 
automatically returned to the same metacodec_class on every iteration.

As it seems the metacodec_class was useless in the first place, I opted 
to remove it. make fate now doesn't hang, but I discovered uhm issues 
with some of the other patches that will be fixed in v2.

I'll be sure to ensure make fate passes all my next patches. Thanks.



More information about the ffmpeg-devel mailing list