[FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

Derek Buitenhuis derek.buitenhuis at gmail.com
Thu Aug 25 19:46:57 EEST 2016

On 8/25/2016 5:34 PM, James Almer wrote:
> On 8/25/2016 12:45 PM, Carl Eugen Hoyos wrote:
>> 2016-08-24 16:55 GMT+02:00 Derek Buitenhuis <derek.buitenhuis at gmail.com>:
>>> This breaks files with legitimate single-entry edit lists,
>>> and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b,
>> I believe "Hack" is not acceptable on this mailing list anymore, please
>> remove it from the commit message.
> Care to point where this was discussed or agreed by the bulk of developers?
> I don't recall anything about it.
> A quick search for "hack" shows a lot of recent results in both the ML and
> the git repo, so I'm not sure why you assumed it's "not acceptable" anymore.

What's a better word? "incorrect workaround"? Am I not allow to say
some code is wrong? Because the code is defacto incorrect.

>>> has no link to any known sample in its commit message
>> I believe a sample is linked in the original commit message,
>> please remove the sentence.

It is not. A filename is not a link. There is no way to locate the
sample solely from the commit message. The description is accurate.

- Derek

More information about the ffmpeg-devel mailing list