[FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

Michael Niedermayer michael at niedermayer.cc
Fri Aug 26 01:01:05 EEST 2016

On Thu, Aug 25, 2016 at 12:31:19PM -0700, Sasi Inguva wrote:
> oops. thanks for pointing that out. Even in our version of ffmpeg, that
> assert doesn't get compiled so we never catched it. That assert logic is
> not correct anymore. At the end of one edit list there can be frames marked
> as discard, for which we would keep increasing the timestamp even if they
> are marked as discard, so that when the timestamps are rerodered to compute
> PTS B-frames get the correct PTS. But the next edit list should always
> start with the timestamp of the last-non-discarded frame of the previous
> edit list. Hence we will get non-increasing timestamps added as index
> entries.
> The test may have passed for you before, because before that line was
> assert(..) instead of av_assert1(...) so maybe that line wasn't getting
> compiled before. Attaching the 4 patches again.

patchset breaks timestamps for audio:
./ffmpeg -i matrixbench_mpeg2.mpg  -t 0.1  one.mov
./ffprobe  -show_packets -print_format compact one.mov

if you look at the audio stream 2 packets have the same pts, that
looks wrong, previously the first packet had -1024


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160826/59100cdc/attachment.sig>

More information about the ffmpeg-devel mailing list