[FFmpeg-devel] [PATCH] avcodec/nvenc: Include nvEncodeAPI v7 SDK header

[Timo Rothenpieler]

On 8/27/2016 3:07 PM, Thomas Volkert wrote:
> Hi,
> 
> On 27.08.2016 14:58, Timo Rothenpieler wrote:
>> As Nvidia has put the most recent Video Codec SDK behind a double
>> registration wall, of which one needs manual approval of a lenghty
>> application, bundling this header saves everyone trying to use NVENC
>> from that headache.
>>
>> The header is still MIT licensed and thus fine to bundle with ffmpeg.
>>
>> Not bundling this header would get ffmpeg stuck at SDK v6, which is
>> still freely available, holding back future development of the NVENC
>> encoder.
>> ---
>>  compat/nvenc/nvEncodeAPI.h | 3219 ++++++++++++++++++++++++++++++++++++++++++++
>>  configure                  |   22 +-
>>  libavcodec/nvenc.h         |    2 +-
>>  3 files changed, 3237 insertions(+), 6 deletions(-)
>>  create mode 100644 compat/nvenc/nvEncodeAPI.h
>>
> 
> But this approach assumes to have SDK version 7 in every case -
> independent from the actually available revision at runtime?
> Is it possible to check the actually available version during runtime?

The header is all SDK the nvenc encoder needs, there is no runtime
component except for the Nvidia driver.

> 
> And I think there are some deprecated comments in nvenc.c:
> - references to only H.264 (HEVC was already added)
> - references to version 5 as "current SDK revision"

There might be some outdated comments left over, but nothing that's a
major documentation issue.
Or do you have something specific in mind?

> 
> Best regards,
> Thomas.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160827/d2d256f1/attachment.sig>