[FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

Thilo Borgmann thilo.borgmann at mail.de
Mon Aug 29 13:45:58 EEST 2016





> Am 28.08.2016 um 22:11 schrieb Michael Niedermayer <michael at niedermayer.cc>:
> 
>> On Sun, Aug 28, 2016 at 09:50:41PM +0200, Hendrik Leppkes wrote:
>> On Sun, Aug 28, 2016 at 9:21 PM, Michael Niedermayer
>> <michael at niedermayer.cc> wrote:
>>> On Sun, Aug 28, 2016 at 12:03:38PM -0300, James Almer wrote:
>>> [...]
>>>> Also, the changelog entry line can be part of the encoder patch, no
>>>> need to have it separate.
>>> 
>>> actually, i was just thinking having Changelog + version + APIChanges
>>> changes separate from the main patch could make sense as these "always"
>>> conflict and need an extra manual
>>> step to work around. Having them separate makes testing slightly
>>> simpler
>>> not specific to this patch of course
>> 
>> Perhaps during development, but it should really be squashed in when
>> its applied then.
> 
> yes of course

The always changing review was my reason to ask Umair to split it. As said, it's not a pain during review then. 

-Thilo


More information about the ffmpeg-devel mailing list