[FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

Michael Niedermayer michael at niedermayer.cc
Tue Aug 30 01:59:33 EEST 2016

On Mon, Aug 29, 2016 at 01:12:10PM -0700, Lucas Cooper wrote:
> > if the user sets output_max without stats_version 2 this would just
> silently ignore the option
> Do you think this warrants a fatal error? A warning seems insufficient as
> the output_max option is explicitly requested by the user.


> > also missing doc/*.texi update

> Should I send that in a followup patch once this one is finalized or would
> you prefer them both in the same patch?

iam fine with either but a single patch for docs and corresponding
feature makes more sense to me


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160830/86619f54/attachment.sig>

More information about the ffmpeg-devel mailing list