[FFmpeg-devel] [PATCH 05/21] libavformat/movenc: mov_write_ftyp_tag: write the major brand a compatible brand

Erkki Seppälä erkki.seppala.ext at nokia.com
Wed Aug 31 13:02:10 EEST 2016

On 08/23/2016 06:35 PM, Yusuke Nakamura wrote:
>> +    if (mov->mode == MODE_MP4 && mov->major_brand)
>> +        ffio_wfourcc(pb, mov->major_brand); /* write major brand as a
>> compatible brand */
> WTF. libavformat has not listed all compatible brands? This is a wrong
> approach if what David Singer (Apple) says is correct. The major_brand
> always be written into compatible_brands in ISOBMFF.

Hmm, so you're saying it should be written unconditionally?

It seems that in many cases it does happen so that the 4cc (ie. mp41) 
ends up being written into the compatible brands as well. But this does 
not happen if the major_brand is explicitly passed as an option.

I have a new patch with a better commit message (but same content).

More information about the ffmpeg-devel mailing list