[FFmpeg-devel] [PATCH 19/21] doc/examples/extract_timed_metadata: added a bare-bones metadata extractor; find only the frames

Michael Niedermayer michael at niedermayer.cc
Wed Aug 31 14:01:44 EEST 2016


On Thu, Aug 25, 2016 at 10:31:57AM +0300, Erkki Seppälä wrote:
> Thanks for pointing out the use of private API. It seemed that this
> would have needed to add a new function for the API for decoding
> timed metadata frames, but probably a better solution is to use the
> avcodec_receive_packet framework for this as the old API is
> deprecated anyway?

thats an option yes

> Below is a patch to introduce the functionality (example edited for
> brevity). If this seems like the way to, I'll add this to v2 of the
> patches. (I may squash the first patch with one of the other patches
> if it fits in.)

it seems ok, assuming it works


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160831/55238c29/attachment.sig>

More information about the ffmpeg-devel mailing list