[FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries
jamrial at gmail.com
Thu Dec 1 00:38:45 EET 2016
On 11/30/2016 7:26 PM, Andreas Cadhalpun wrote:
> On 30.11.2016 22:55, Ronald S. Bultje wrote:
>> On Wed, Nov 30, 2016 at 4:51 PM, Andreas Cadhalpun <
>> andreas.cadhalpun at googlemail.com> wrote:
>>> On 30.11.2016 19:16, Vittorio Giovara wrote:
>>> You can't just add a gap like that.
>>> The current code assumes that the numbers are consecutive, like e.g. the
>>> naming of AVCOL_PRI_NB suggests.
>> No, we've had gaps in these before.
> In AVColorPrimaries?
>> Whether all code works correctly with gaps is a separate thing, but gaps
>> are intended and have existed.
> Without this patch there is no need for code to take gaps in AVColorPrimaries
> into account, so it's no bug if it doesn't.
> As such this patch would (indirectly) introduce those bugs, which is why
> the code should be changed to take gaps into account before this patch
> is applied.
Vittorio sent a couple patches that do this to libav, for that matter. I guess
we can expect them sent here as well.
More information about the ffmpeg-devel