[FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

Nicolas George george at nsup.org
Thu Dec 1 21:22:40 EET 2016

Le primidi 11 frimaire, an CCXXV, Rostislav Pehlivanov a écrit :
> Why do you insist on having a hole in the first place?

Apparently, the values of the enum are used encode and decode
standardized values in standardized formats like MPEG.

I think this is a terrible design decision, and I would like to suggest
to change it before it is too late.

It will lead to all kinds of trouble if we want to support primaries
from other standards with conflicting values, or if the standards
introduce huge gaps in their allocated values.

The correct way of dealing with that kind of situation is the same as
what we have always done for 4CCs: have tables (or other kinds of
conversion functions) matching the value of the enum in our API with the
value for a corresponding standard. The name of the table must include
the name of the standard.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161201/5ed35569/attachment.sig>

More information about the ffmpeg-devel mailing list