[FFmpeg-devel] [PATCH] avformat/utils: fix crashes in has_decode_delay_been_guessed

Timo Rothenpieler timo at rothenpieler.org
Fri Dec 2 18:05:29 EET 2016

> Is it just me or is this completely inconsistent?
> the codec id told to the user is h264 while we internally use a
> mpeg2 decoder to analyze it ?
> If its h264 (as forced by the user) we should use a h264 decoder
> to internally analyze it

Yes, something is very wrong here.
I also wasn't able to reproduce this with any self made sample. Only the
one from Ticket 5985 makes it crash for me. In two separate ways even.
In one case, the avctx->codec is NULL, because there are unknown codecs
in that sample, and in other cases the codecs mismatch.

I don't have time to take an in depth look at what is going on there, so
for now I decided to harden it against crashes, which is probably a good
idea in any case.

If this patch gets merged, it should also be backported to at least 3.2

More information about the ffmpeg-devel mailing list