[FFmpeg-devel] [PATCH 1/5] avformat/ffmdec: Remove some st->codec uses which set encoder parameters

Moritz Barsnick barsnick at gmx.net
Mon Dec 5 01:28:49 EET 2016

On Sat, Dec 03, 2016 at 13:23:26 +0100, Michael Niedermayer wrote:
> > Please add a comment like /* gop_size */ here and similar ones below.
> > Otherwise it'll be rather mysterious what's the point of all these avio_rb* calls.
> done locally

Are the remaining avio_rb*() calls good for anything except documenting
the now unused fields? I know the code is just called once for the
headers, but replacing N avio_rb*() calls with a single avio_skip()
would be way more efficient, right?


More information about the ffmpeg-devel mailing list