[FFmpeg-devel] [PATCH 3/4] mov: Export spherical information
jamrial at gmail.com
Tue Dec 6 20:05:46 EET 2016
On 12/6/2016 2:37 PM, Vittorio Giovara wrote:
> On Tue, Dec 6, 2016 at 11:06 AM, James Almer <jamrial at gmail.com> wrote:
>> On 11/30/2016 9:12 PM, James Almer wrote:
>>> On 11/30/2016 8:36 PM, Vittorio Giovara wrote:
>>>> This implements Spherical Video V1 and V2, as described in the
>>>> spatial-media collection by Google.
>>>> Signed-off-by: Vittorio Giovara <vittorio.giovara at gmail.com>
>>>> This addresses all comments from James.
>>> LGTM, at least the V2 part. Seems to follow the spec right now.
>>> Will trust you on the V1 part :P.
> Hopefully V1 is going to disappear soon. Thanks for the review, I've
> sent a minor documentation update which reflects the latest change to
> the specification, I hope that is fine too.
>>> I have written a Matroska implementation of this spec, for that
>>> matter. Will send it after this patchset is committed.
> Oh cool, do you have or need a file to test (and/or add a fate)?
I wrote a muxer implementation and remuxed the mov file currently in
the FATE samples suite to test the demuxer implementation. You can
download it here: http://0x0.st/Lpj.mkv
I wont be sending the muxer implementation since i had to hack in
the projection specific private data to create that file, as it's
not part of AVSphericalMapping.
I could use an actual file created by Google to make sure i got it
right, but the spec is very clear and our Matroska de/muxers allow
one to add new elements with a few lines.
I'm attaching the demuxer implementation if you want to look at it
and test it.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 6413 bytes
Desc: not available
More information about the ffmpeg-devel