[FFmpeg-devel] [PATCH] yuv4mpegdec: fix leaking pkt in yuv4_read_packet

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Thu Dec 8 01:28:38 EET 2016


On 07.12.2016 03:18, Michael Niedermayer wrote:
> On Mon, Dec 05, 2016 at 11:08:44PM +0100, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  libavformat/yuv4mpegdec.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c
>> index a91645f..462b823 100644
>> --- a/libavformat/yuv4mpegdec.c
>> +++ b/libavformat/yuv4mpegdec.c
>> @@ -295,9 +295,10 @@ static int yuv4_read_packet(AVFormatContext *s, AVPacket *pkt)
>>      ret = av_get_packet(s->pb, pkt, s->packet_size - Y4M_FRAME_MAGIC_LEN);
>>      if (ret < 0)
>>          return ret;
>> -    else if (ret != s->packet_size - Y4M_FRAME_MAGIC_LEN)
>> +    else if (ret != s->packet_size - Y4M_FRAME_MAGIC_LEN) {
>> +        av_packet_unref(pkt);
>>          return s->pb->eof_reached ? AVERROR_EOF : AVERROR(EIO);
>> -
>> +    }
> 
> LGTM

Pushed.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list