[FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

Ronald S. Bultje rsbultje at gmail.com
Thu Dec 8 21:05:19 EET 2016


Hi,

On Thu, Dec 8, 2016 at 1:25 PM, James Almer <jamrial at gmail.com> wrote:

> On 12/8/2016 2:44 PM, Ronald S. Bultje wrote:
> > Hi,
> >
> > On Thu, Dec 8, 2016 at 12:37 PM, Michael Niedermayer
> <michael at niedermayer.cc
> >> wrote:
> >
> >> Suggested-by: Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>
> >> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >> ---
> >>  libavformat/options_table.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/libavformat/options_table.h b/libavformat/options_table.h
> >> index d5448e503f..19cb87ae4e 100644
> >> --- a/libavformat/options_table.h
> >> +++ b/libavformat/options_table.h
> >> @@ -105,7 +105,7 @@ static const AVOption avformat_options[] = {
> >>  {"format_whitelist", "List of demuxers that are allowed to be used",
> >> OFFSET(format_whitelist), AV_OPT_TYPE_STRING, { .str = NULL },
> CHAR_MIN,
> >> CHAR_MAX, D },
> >>  {"protocol_whitelist", "List of protocols that are allowed to be used",
> >> OFFSET(protocol_whitelist), AV_OPT_TYPE_STRING, { .str = NULL },
> CHAR_MIN,
> >> CHAR_MAX, D },
> >>  {"protocol_blacklist", "List of protocols that are not allowed to be
> >> used", OFFSET(protocol_blacklist), AV_OPT_TYPE_STRING, { .str = NULL },
> >> CHAR_MIN, CHAR_MAX, D },
> >> -{"max_streams", "maximum number of streams", OFFSET(max_streams),
> >> AV_OPT_TYPE_INT, { .i64 = INT_MAX }, 0, INT_MAX, D },
> >> +{"max_streams", "maximum number of streams", OFFSET(max_streams),
> >> AV_OPT_TYPE_INT, { .i64 = 100 }, 0, INT_MAX, D },
> >>  {NULL},
> >>  };
> >
> >
> > Isn't this - in some way - an ABI break?
> >
> > Ronald
>
> The option in question was added an hour ago, so no.


I meant that legal input with 101 streams stop working. That's not crazy
IMO. IOW, 100 is kinda low.

Ronald


More information about the ffmpeg-devel mailing list