[FFmpeg-devel] [PATCH v3] Added Turing codec interface for ffmpeg
h.leppkes at gmail.com
Wed Dec 14 16:32:16 EET 2016
On Wed, Dec 14, 2016 at 3:23 PM, Matteo Naccari
<Matteo.Naccari at bbc.co.uk> wrote:
>> Missing error handling, and maybe overflow handling. Also, we don't use
>> malloc/realloc/free, but av_malloc/av_realloc/av_free. I'm not sure why we
>> do this (it doesn't have much of a justification for realloc at least), but it's
>> probably better to be consistent.
> Ok, point taken on the av_* functions. On the handling bit, I was thinking to flag the error via av_log and then call exit_program(1), after, of course, having released the memory allocated up to that point. Would that be ok?
Calling exit or abort from a library is never ok. Just return error
codes back to the avcodec framework and let it handle the error
instead of exiting right here.
More information about the ffmpeg-devel