[FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

Nicolas George george at nsup.org
Sun Dec 18 21:52:33 EET 2016

L'octidi 28 frimaire, an CCXXV, James Almer a écrit :
> You didn't answer what's the gain here.

Yes I did: discuss that with Hendrik, Andreas and Clément, not me.

>					 How is this better than keeping the
> struct public and letting library users keep accessing its fields normally?
> Why are you trying to make libavfilter so different than the rest? We have
> scheduled the deprecation and removal of /all/ accessors, and now you want
> to add more?

I think you did not read the code carefully enough. These accessors, on
top of addressing Hendrik, Andreas and Clément's concerns, make the code
actually more robust and readable.

> If people didn't use lavfi before, they will feel less motivated to do it
> now since they can't even expect consistency with lavf or lavc.

Once again: consistency is only a means to an end.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161218/252c86f6/attachment.sig>

More information about the ffmpeg-devel mailing list