[FFmpeg-devel] [PATCHv3] af_hdcd: more FATE tests

Michael Niedermayer michael at niedermayer.cc
Mon Dec 19 02:54:23 EET 2016

On Sun, Dec 18, 2016 at 12:48:45PM -0600, Burt P wrote:
> Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%.
> Changed fate-suite sample files:
> * filter/hdcd-encoding-errors.flac (1.3M) replaced by
>   a smaller version (140K). It can be replaced because the test
>   only looks for a non-zero number of errors, so the existing test
>   will still pass.

IMO replacing files is not ok
it would change all past instances of the related fate test
a bug report refering to a fate failure could become unreproduceable
or otherwise working fate tests could start failing ...
as much as i prefer to safe a few bytes in this case i prefer to waste
some space over the potential problems

you can add files, but not remove or replace unless they are truly
unused by every past checkout

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161219/03807102/attachment.sig>

More information about the ffmpeg-devel mailing list