[FFmpeg-devel] [PATCH] lavf/matroska: comment a missing error check.

[Nicolas George]

Signed-off-by: Nicolas George <george at nsup.org>
---
 libavformat/matroskaenc.c | 1 +
 1 file changed, 1 insertion(+)


I do not have time to fix this, but I got a few segfaults here, so it needs
to be fixed. Either push the patch or, better push an actual fix.


diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 827d7550c2..8e536f6774 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -351,6 +351,7 @@ static void end_ebml_master_crc32(AVIOContext *pb, AVIOContext **dyn_cp, Matrosk
 
     if (pb->seekable) {
         size = avio_close_dyn_buf(*dyn_cp, &buf);
+        /* FIXME missing error check */
         if (mkv->write_crc && mkv->mode != MODE_WEBM) {
             skip = 6; /* Skip reserved 6-byte long void element from the dynamic buffer. */
             AV_WL32(crc, av_crc(av_crc_get_table(AV_CRC_32_IEEE_LE), UINT32_MAX, buf + skip, size - skip) ^ UINT32_MAX);
-- 
2.11.0