[FFmpeg-devel] [PATCH 6/9] lavfi: move AVFilterLink declaration to its own header.

James Almer jamrial at gmail.com
Tue Dec 27 21:25:59 EET 2016

On 12/27/2016 3:38 PM, Nicolas George wrote:
> Le septidi 7 nivôse, an CCXXV, James Almer a écrit :
>> How is this any different than the above notice? Everything below time_base
>> is also meant for internal use and shouldn't be accessed by applications or
>> other ffmpeg libraries.
>> Is extending the scope of FF_INTERNAL_FIELDS to cover the above fields your
>> intention for the next major bump?
>> What's the point in reserving space like this? And isn't 60kb a bit overkill?
>> I insist this is just ugly and unconventional.
> You are late, this is not new code, just moved.

It may not be something added with this patchset, but It's pretty much new and
recent code, questioned by more people than just me prior to it being pushed.
I think making questions and complaining about its ugly and unconventional nature
is something i'm allowed to do, especially when it was pushed while blocking
technical reviews were purposely unaddressed at the time.

It's clear you're on the defensive and think I'm just attacking you for the sake
of it, so trying to discuss with you will be pointless. Nothing good will come
out of this at this point, from either of us.

More information about the ffmpeg-devel mailing list