[FFmpeg-devel] [PATCH 12/17] lavfi: move ff_update_link_current_pts() into the utility functions.

Nicolas George george at nsup.org
Sat Dec 31 15:29:45 EET 2016


Le primidi 11 nivôse, an CCXXV, Michael Niedermayer a écrit :
> slightly off topic but ff_update_link_current_pts() has no
> documentation in the header

I also noticed it. Also, it is now only used in avfilter.c, so it could
be made static. I will have to address it when I get to maintaining a
priority queue of filters that are ready and deprecating
avfilter_graph_request_oldest(), since they are related
(ff_update_link_current_pts() maintains a heap of sink links by
timestamp).

> also the commit message is a bit terse, why is it moved
> does this add or remove calls to it in some codepathes ?

I reworded it as:

    lavfi: move ff_update_link_current_pts() into the utility functions.
    
    It does not change anything for the existing filters and makes
    better code fatrorization when future code will use the utility
    functions.

My reason to have it in a separate commit is to be able to run FATE
before and after the change to check it did not break anything.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161231/9cd50819/attachment.sig>


More information about the ffmpeg-devel mailing list