[FFmpeg-devel] [PATCH 2/2] Update demuxers and protocols for protocol whitelist support

[Michael Niedermayer]

On Tue, Feb 02, 2016 at 12:45:32AM +0100, Andreas Cadhalpun wrote:
> On 30.01.2016 02:17, Michael Niedermayer wrote:
> > From: Michael Niedermayer <michael at niedermayer.cc>
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavdevice/lavfi.c               |    7 ++++++-
> >  libavformat/async.c               |    2 +-
> >  libavformat/cache.c               |    3 ++-
> >  libavformat/concat.c              |    6 ++++--
> >  libavformat/crypto.c              |    5 +++--
> >  libavformat/dashenc.c             |    9 +++++----
> >  libavformat/file.c                |    2 ++
> >  libavformat/ftp.c                 |   11 +++++++----
> >  libavformat/gopher.c              |    4 ++--
> >  libavformat/hdsenc.c              |   13 +++++++------
> >  libavformat/hls.c                 |    8 +++++---
> >  libavformat/hlsenc.c              |   29 +++++++++++++++--------------
> >  libavformat/hlsproto.c            |   11 +++++++----
> >  libavformat/http.c                |   18 ++++++++++++------
> >  libavformat/icecast.c             |    3 ++-
> >  libavformat/md5proto.c            |    5 +++--
> >  libavformat/mmst.c                |    5 +++--
> >  libavformat/movenc.c              |    2 +-
> >  libavformat/rtmpcrypt.c           |    5 +++--
> >  libavformat/rtmpproto.c           |   10 ++++++----
> >  libavformat/rtpproto.c            |   10 +++++++---
> >  libavformat/rtsp.c                |   20 ++++++++++----------
> >  libavformat/rtspdec.c             |   10 ++++++----
> >  libavformat/sapdec.c              |    5 +++--
> >  libavformat/sapenc.c              |    9 ++++++---
> >  libavformat/segment.c             |   17 +++++++++--------
> >  libavformat/smoothstreamingenc.c  |   19 +++++++++++--------
> >  libavformat/srtpproto.c           |    3 ++-
> >  libavformat/subfile.c             |    4 +++-
> >  libavformat/tee.c                 |    5 ++++-
> >  libavformat/tls.c                 |    5 +++--
> >  libavformat/tls_securetransport.c |    5 +++--
> >  libavformat/webm_chunk.c          |    8 +++++---
> >  33 files changed, 168 insertions(+), 110 deletions(-)
> 
> Should be fine.
> 
> On 30.01.2016 01:58, Michael Niedermayer wrote:
> > On Sat, Jan 30, 2016 at 12:03:48AM +0100, Andreas Cadhalpun wrote:
> >> This looks mostly fine. I tested a few protocols and it worked as intended.
> >> However, it doesn't forward the whitelist when ffurl_connect is called directly, which
> >> happens in the hls demuxer and the mmsh, rtmphttp and rtsp protocols.
> >> I think that should be done, too.
> > 
> > fixed hls, others left to volunteers, i have no testcases for them
> 
> I don't see how hls is fixed, but don't have testcases either.
> Anyway, the following should work:

the hls segfaulted
i somehow must have lost the hunk that fixed it

pushed with the fix
i left the rtp stuff as its your code and shuld be commited under
your name as author

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160202/cc0df0b6/attachment.sig>