[FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Mon Jan 4 21:32:18 CET 2016

On 04.01.2016 21:18, Thilo Borgmann wrote:
> Am 04.01.16 um 18:31 schrieb Derek Buitenhuis:
>> On 1/4/2016 3:18 PM, Andreas Cadhalpun wrote:
>>> Supporting this would require re-initialization to change buffer sizes.
>> I may be mistaken, but don't we already support some codecs which do
>> this, properly?
> I'm quite sure that changing the number of channels is invalid for ALS
> so there is no sense in implementing it.


> However, we should should add a fix for out-of-bound reads. An updated
> patch giving a proper error would do, I think.

I'm not sure that would have much use as this only happens if the API
isn't used as intended (ac3 parser with als decoder).

It might be better to check that parsers are used with matching decoders,
if such a check can be implemented.

Best regards,

More information about the ffmpeg-devel mailing list