[FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Tue Jan 5 12:48:10 CET 2016

On 05.01.2016 12:18, Michael Niedermayer wrote:
> On Tue, Jan 05, 2016 at 12:02:29PM +0100, Andreas Cadhalpun wrote:
>> That wouldn't work, as the codec id wasn't changed in force_codec_ids,
>> but in the API using program.
>> To reiterate, the problematic steps were:
>>  * call avformat_find_stream_info, which detects a codec and initializes
>>    a parser for it
>>  * afterwards change the codec id in the API using program, so it
>>    doesn't match with the parser
>> Thus I think the only reliable way to detect this is a check in av_parser_parse2.
> shouldnt this be a av_assert1/2() then ?
> i mean this is a programming error in the user app not a error
> condition that should happen that way in correct usage
> IMHO if we need 5 extra checks thats fine but if this is just to
> detect a user app bug then iam not sure these checks should be run
> for every packet

I would prefer av_assert0, but if you think that could cause relevant slowdowns,
I'm also fine with av_assert1. Patch for that attached.

Best regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-parser-add-av_assert1-to-make-sure-the-codec-matches.patch
Type: text/x-diff
Size: 1273 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160105/792b6bb5/attachment.patch>

More information about the ffmpeg-devel mailing list