[FFmpeg-devel] [PATCH] ffmpeg: check return value of avio_closep for progress report

Michael Niedermayer michael at niedermayer.cc
Tue Jan 5 18:08:59 CET 2016

On Mon, Jan 04, 2016 at 07:39:42PM -0800, Ganesh Ajjanagadde wrote:
> avio_closep is not guaranteed to succeed, and its return value can
> contain information regarding failure of preceding writes and silent
> loss of data (man 2 close, man fclose). Users should know when the
> progress was not successfully logged, and so a diagnostic is printed
> here.
> The reason only one of these is changed in the patch is to get feedback:
> a quick glance shows a large number of unchecked avio_close operations.
> It may be tedious to check all of them, and relative importance varies
> across instances. This was one which I feel is important.
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
>  ffmpeg.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

patch LGTM


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160105/8d91f548/attachment.sig>

More information about the ffmpeg-devel mailing list