[FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.
jzern at google.com
Fri Jan 8 03:35:29 CET 2016
On Mon, Jan 4, 2016 at 12:26 PM, James Almer <jamrial at gmail.com> wrote:
> On 1/4/2016 5:01 PM, Sasi Inguva wrote:
>> Would it be a lot easier and correct if I just update the IMAGE_ABI_VERSION to 4 in libvpx HEAD and check here in the decoder IMAGE_ABI_VERSION > 3 ?
> Yes, bumping any of the defines would probably be best. It will not apply
> to libvpxdec 1.5.0, though, but i guess it's better than bloating configure
> with checks for specific struct members.
I agree, though for this if you wanted compatibility, since the values
are defined by the bitstream, using 0/1 would be enough; the enum is
>> On Mon, Jan 4, 2016 at 11:03 AM, Ronald S. Bultje <rsbultje at gmail.com <mailto:rsbultje at gmail.com>> wrote:
>> On Mon, Jan 4, 2016 at 1:48 PM, Sasi Inguva <isasi at google.com <mailto:isasi at google.com>> wrote:
>> > Ping! I could not find any other fields for version other than the
>> > IMAGE_ABI_VERSION , CODEC_ABI_VERSION, DECODER_ABI_VERSION which remain
>> > unchanged .
>> So, add a version check? Or check for the existence of the appropriate
>> color range field in this struct in our configure script.
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org <mailto:ffmpeg-devel at ffmpeg.org>
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel