[FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

Mats Peterson matsp888 at yahoo.com
Tue Jan 12 06:30:02 CET 2016

On 01/12/2016 05:48 AM, Ganesh Ajjanagadde wrote:
>> You're free to make another patch, or if perhaps I should do it.
> If something is inherently 32 bits (e.g obtained by reading 4 bytes),
> then please don't make such a patch.
> Seems to be the case here, and so I would nack such a patch:
> color_start is obtained by an avio_rb32, keeping as uint32_t is
> cleaner.
No we'll skip it in my book. I don't see reason enough to change it. 
Thanks for your input, Ganesh.


More information about the ffmpeg-devel mailing list