[FFmpeg-devel] [PATCH 00/13] check all fclose usage

wm4 nfxjfg at googlemail.com
Tue Jan 12 10:38:03 CET 2016

On Mon, 11 Jan 2016 23:25:02 -0500
Ganesh Ajjanagadde <gajjanagadde at gmail.com> wrote:

> Some preliminary work has already been done on fclose checking. This completes
> the work, modulo a few exceptions:

1. Printing warnings is completely useless unless maybe in ffmpeg.c
interactive usage (if the user has good eyes). For API users or
ffmpeg.c automated shell scripts this helps absolutely nothing.
2. There are some "theoretical" checks for fclose() on files opened in
read-only mode. This makes no sense. Even if fclose() should fail for
whatever obscure reasons there might be, reading already worked
without errors, and thus closing failure has no meaning to use.

Just what is the point?

More information about the ffmpeg-devel mailing list