[FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

Mats Peterson matsp888 at yahoo.com
Wed Jan 13 00:28:52 CET 2016

On 01/12/2016 10:44 PM, Andreas Cadhalpun wrote:
>> Why are we using stdint types for non-vector data here? Our custom has
>> always been to used sized (stdint-style) data only for vector data (arrays
>> etc.), and use native-sized types (e.g. unsigned, int, whatever) for scalar
>> values. Why are we making exceptions here?
> I can't find this convention in our coding rules[1].
> The main reason why I used uint32_t instead of unsigned here was consistency
> with the line below. But as Ganesh explained it makes prefect sense to use
> uint32_t at least for color_start.

Yes it does.

More information about the ffmpeg-devel mailing list