[FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Tue Jan 19 21:41:32 CET 2016

On 19.01.2016 21:31, Hendrik Leppkes wrote:
> On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun
> <andreas.cadhalpun at googlemail.com> wrote:
>> On 19.01.2016 21:22, Hendrik Leppkes wrote:
>>> On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun
>>> <andreas.cadhalpun at googlemail.com> wrote:
>>>> On 22.10.2015 11:44, Hendrik Leppkes wrote:
>>>> They now made VLC's configure error out when compiling with FFmpeg [1],
>>>> because they currently lack time [2] to fix this the way you suggest
>>>> and Libav doesn't return this error.
>>> They don't lack time, they lack understanding of the flaws in the system.
>> How can you know that?
> Because I read the ticket, which says he doesn't want to do it, not
> that he doesn't have time to do it, and because I know that particular
> person and his attitude.

Let's not get personal, please.

>>>> Thus I think it would be better to reduce this to a warning for the
>>>> time being and maybe add a FF_API_* changing it to an error after
>>>> the usual deprecation period.
>>> I do not agree that it should be a warning. As outlined in the commit
>>> message and this thread, there are serious flaws with frame threading
>>> and hwaccel.
>> I'm fine with it being an error, but since it is an API change, it
>> should follow the usual deprecation period to allow downstream users
>> time to fix it. Meanwhile it can be a warning so that people notice
>> the problem.
> Its fundamentally broken, and making it a warning would re-introduce
> known crashes. So no.

What do other developers think about this?

Best regards,

More information about the ffmpeg-devel mailing list