[FFmpeg-devel] [PATCH] avcodec: only warn about hwaccel with frame threads

Hendrik Leppkes h.leppkes at gmail.com
Sat Jan 23 12:19:00 CET 2016


On Sat, Jan 23, 2016 at 12:10 PM, Andreas Cadhalpun
<andreas.cadhalpun at googlemail.com> wrote:
> On 23.01.2016 11:42, Hendrik Leppkes wrote:
>> On Sat, Jan 23, 2016 at 10:12 AM, Andreas Cadhalpun
>> <andreas.cadhalpun at googlemail.com> wrote:
>>> VLC uses hwaccel with frame threads and it works fine, but returning
>>> an error here made it fail.
>>>
>>> This regression was introduced in commit 31741ae.
>>>
>>
>> I'm still opposed to this, and so is everyone else that commented on the issue.
>
> That's not true.
>
>> Also, the vp9 hwaccel will most definitely misbehave with MT, so this
>> one needs to be re-factored before MT is allowed at the very least.
>
> Feel free to propose an alternative patch fixing the regression your
> commit introduced. But unless you do so soon, I intend to apply this
> patch to make VLC with hwaccel usable again until you find a better
> solution.
>

Applying a patch that knowingly breaks code with opposition from a
developer is not acceptable.


More information about the ffmpeg-devel mailing list