[FFmpeg-devel] [PATCH] avcodec: only warn about hwaccel with frame threads

Ronald S. Bultje rsbultje at gmail.com
Sat Jan 23 14:10:56 CET 2016


On Sat, Jan 23, 2016 at 6:10 AM, Andreas Cadhalpun <
andreas.cadhalpun at googlemail.com> wrote:

> On 23.01.2016 11:42, Hendrik Leppkes wrote:
> > On Sat, Jan 23, 2016 at 10:12 AM, Andreas Cadhalpun
> > <andreas.cadhalpun at googlemail.com> wrote:
> >> VLC uses hwaccel with frame threads and it works fine, but returning
> >> an error here made it fail.
> >>
> >> This regression was introduced in commit 31741ae.
> >>
> >
> > I'm still opposed to this, and so is everyone else that commented on the
> issue.
> That's not true.
> > Also, the vp9 hwaccel will most definitely misbehave with MT, so this
> > one needs to be re-factored before MT is allowed at the very least.
> Feel free to propose an alternative patch fixing the regression your
> commit introduced. But unless you do so soon, I intend to apply this
> patch to make VLC with hwaccel usable again until you find a better
> solution.

You guys need a mediator, I hear JB is very good at that. Neither of you is
listening at all to what the other person is saying.

Can you two figure out what is working, what is not, under what conditions,
and document that in a way that is understandable to dumb people like me? I
bet you that after that, the solution will be trivial. It can't be hard to
test (for both of you) on a set of systems which hardware accels work and
which don't (under ffmpeg/ffplay or vlc or mpv or whatnot) with/without
threading and which codecs. These are technical tests where we should all
be able to agree on the results.


More information about the ffmpeg-devel mailing list