[FFmpeg-devel] [PATCH 1/2] dirac: Move quantization tables to the shared header file

Michael Niedermayer michael at niedermayer.cc
Sat Jan 23 17:28:16 CET 2016

On Fri, Jan 22, 2016 at 06:15:42PM +0000, Rostislav Pehlivanov wrote:
> This commit moves the quantization matricies and a single define to the
> shared header between the encoder and decoder. This is in preparation
> for the following commit which will introduce the encoder.
> Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>
> ---
>  libavcodec/dirac.h    | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/diracdec.c | 78 ---------------------------------------------------
>  2 files changed, 78 insertions(+), 78 deletions(-)

shouldnt the common tables be in a direcwhatever.c that gets build
once and used by both encoder and decoder ?

the patch is fine if the duplication is intended

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160123/85ad05fa/attachment.sig>

More information about the ffmpeg-devel mailing list