[FFmpeg-devel] [PATCH] avfilter: add nnedi filter

Michael Niedermayer michael at niedermayer.cc
Sun Jan 24 12:03:50 CET 2016


On Sun, Jan 24, 2016 at 10:50:37AM +0100, Paul B Mahol wrote:
> On 1/24/16, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote:
> >> Hi,
> >>
> >> patch attached.
> >
> >>  configure                |    1
> >>  libavfilter/Makefile     |    1
> >>  libavfilter/allfilters.c |    1
> >>  libavfilter/vf_nnedi.c   |  939
> >> +++++++++++++++++++++++++++++++++++++++++++++++
> >>  4 files changed, 942 insertions(+)
> >> fd0161c6e14c0f39f4fc344c1737713691a13f1d
> >> 0001-avfilter-add-nnedi-filter.patch
> >> From a41c741bb4d3146661e629552d750638a0bdc87c Mon Sep 17 00:00:00 2001
> >> From: Paul B Mahol <onemda at gmail.com>
> >> Date: Sat, 23 Jan 2016 17:15:53 +0100
> >> Subject: [PATCH] avfilter: add nnedi filter
> >>
> >> Port of nnedi3 vapoursynth filter.
> >
> > nice
> >
> > this produces some warnings though
> >
> > libavfilter/vf_nnedi.c: In function `copyPad':
> > libavfilter/vf_nnedi.c:157:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:188:13: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:201:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c: In function `computeNetwork0_C':
> > libavfilter/vf_nnedi.c:245:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c: In function `computeNetwork0_i16_C':
> > libavfilter/vf_nnedi.c:262:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c: In function `computeNetwork0new_C':
> > libavfilter/vf_nnedi.c:331:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:340:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c: In function `evalFunc_0':
> > libavfilter/vf_nnedi.c:360:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:374:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:378:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c: In function `extract_m8_C':
> > libavfilter/vf_nnedi.c:425:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:427:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c: In function `extract_m8_i16_C':
> > libavfilter/vf_nnedi.c:449:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c: In function `evalFunc_1':
> > libavfilter/vf_nnedi.c:503:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:517:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:524:17: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:530:17: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c: In function `filter_frame':
> > libavfilter/vf_nnedi.c:615:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:626:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:629:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:635:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:657:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c: In function `init':
> > libavfilter/vf_nnedi.c:713:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:729:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:740:5: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:770:9: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:787:13: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:812:17: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:864:17: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> > libavfilter/vf_nnedi.c:874:17: warning: ISO C90 forbids mixed declarations
> > and code [-Wdeclaration-after-statement]
> 
> Hey, its 21 century!

if no supported platform has a problem with this anymore and noone
objects then the warning should be disabled


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160124/2f409efd/attachment.sig>


More information about the ffmpeg-devel mailing list