[FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds
andreas.cadhalpun at googlemail.com
Sun Jan 24 19:31:28 CET 2016
On 24.01.2016 18:58, Nicolas George wrote:
> Le quintidi 5 pluviôse, an CCXXIV, Ronald S. Bultje a écrit :
>> I think Andreas' original patch removed that so in-tree and out-tree builds
>> are bit-exact (i.e. the pathnames to in-tree source files are identical
>> between the two build types).
>> I don't know if that's worth it. Andreas seems to claim it is, others seem
>> to doubt it...
> Theoretically, I believe that identical builds are worth it.
> But I just realized that Andreas' patch does it the wrong way, IMHO: it
> include the full path in the resulting binary.
> With the current tree, the
> source path arrives in the final binary, even the stripped one. This is
> severely wrong as it leaks private information.
I can't reproduce this. The path is only included in the debugging information.
And that happened even more before my change.
More information about the ffmpeg-devel