[FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

Timothy Gu timothygu99 at gmail.com
Sun Jan 24 22:46:50 CET 2016

On Sun, Jan 24, 2016 at 10:21:14PM +0100, Andreas Cadhalpun wrote:
> That's not very reasonable.
> Other changes also broke things that worked before.
> For example before commit 94c20de one could build ffmpeg with x265 version
> X265_BUILD 17, and afterwards it requires at least X265_BUILD 57.

That effect is well-known during the review stage, and has been approved by
the community.

The side effect of your commit, namely, that it will break MSVC, was NOT known
during the review stage (if there was one) of your patches.

> That's also a regression, but the workaround is to use a newer x265 version.

Well-thought out and approved-by-community regressions are not regressions
that need to be "fixed."

This argument also applies to the hwaccel situation: the community is aware of
VLC's using MT during review and with that awareness the patch is passed.

People do make mistakes,[1] and the correct attitude is to listen to the
majority, which in this case is nontrivial.

Most of us do not have ANY problems with your original patch. We DO have
problem with the way you handle bugs introduced in your patch, which are

[1]: https://trac.ffmpeg.org/ticket/5183


More information about the ffmpeg-devel mailing list