[FFmpeg-devel] [PATCH v3] lavc/rawdec: Use AV_PIX_FMT_PAL8 for 1-bit raw AVI video

Michael Niedermayer michael at niedermayer.cc
Mon Jan 25 01:57:56 CET 2016

On Mon, Jan 25, 2016 at 01:54:22AM +0100, Mats Peterson wrote:
> On 01/25/2016 01:52 AM, Michael Niedermayer wrote:
> >On Mon, Jan 25, 2016 at 01:39:13AM +0100, Mats Peterson wrote:
> >>On 01/25/2016 01:31 AM, Mats Peterson wrote:
> >>>On 01/25/2016 01:30 AM, Mats Peterson wrote:
> >>>
> >>>>Well, this one is still incorrect, since it doesn't cater for different
> >>>>strides.
> >>>>
> >>>>Mats
> >>>>
> >>>
> >>>I would like you to focus on version 5 that I've both mailed to you and
> >>>posted here.
> >>>
> >>>Mats
> >>>
> >>
> >>And why did you omit the 8 bpp changes for AVI? That's what this
> >>patch (or version 5 rather) is about.
> >
> >put bluntly, because iam not convinced that this is valid in AVI
> >
> >IIUC you created a avi file with a palette and a blue entry and 1bpp
> >and then modified ffmpeg to display that with blue.
> >ok
> >but
> >is that correct, does microsofts player display that with blue too?
> >does the AVI spec say that 1bpp has a palette?
> >do unmodified avi files exist out in the wild that have 1bpp palettes?
> >
> >if 1bpp in AVI is per spec and MS reference supposed to have a palette
> >then we should too and iam happy with the change otherwise we should
> >keep mono for avi
> >
> Microsoft's player doesn't even play raw 1-bit video for some
> reason, but that's not our problem, is it? All the documentation on
> Microsoft's site on 1-bit video tells us that it's palettized and
> not simply black & white. 1, 4, and 8 bit modes, all of them use the
> palette, if any, following the BITMAPINFOHEAER. 2-bit mode isn't
> even official, but still exists in FFmpeg.

do you have a link to these 1bpp palette docs ?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160125/0b55f097/attachment.sig>

More information about the ffmpeg-devel mailing list