[FFmpeg-devel] [PATCHv3] avcodec: Cineform HD Decoder

[Rostislav Pehlivanov]

On 25 January 2016 at 00:34, Kieran Kunhya <kieran at kunhya.com> wrote:

> Decodes YUV 4:2:2 10-bit and RGB 12-bit files.
> Older files with more subbands, skips, Bayer, alpha not supported.
> Alpha requires addition of GBRAP12 pixel format.
> ---
>  libavcodec/Makefile     |   1 +
>  libavcodec/allcodecs.c  |   1 +
>  libavcodec/avcodec.h    |   1 +
>  libavcodec/cfhd.c       | 744
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/cfhd.h       | 107 +++++++
>  libavcodec/cfhddata.c   | 327 +++++++++++++++++++++
>  libavcodec/codec_desc.c |   7 +
>  libavformat/riff.c      |   1 +
>  8 files changed, 1189 insertions(+)
>  create mode 100644 libavcodec/cfhd.c
>  create mode 100644 libavcodec/cfhd.h
>  create mode 100644 libavcodec/cfhddata.c
>
> diff --git a/libavcodec/Makefile b/libavcodec/Makefile


Something minor: replace the 2 "for (;;)" loops with a "while (1)". The
rest of the (modern) code uses this notation. Any compilers that don't
support this have long been unsupported.
Otherwise LGTM