[FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

Michael Niedermayer michael at niedermayer.cc
Sun Jan 31 15:07:46 CET 2016

On Sun, Jan 31, 2016 at 01:27:22PM +0100, Mats Peterson wrote:
> I don't really appreciate that you're doing things behind my back,
> Michael. There's nothing mentioned on the ffmpeg-devel mailing lis

indeed, i should have clearly stated that i applied the pal8
patches with the plan to use pal8 only when neccessary.
I had asked you to implement exactly that but it seemed you didnt
know how to do that cleanly and simply so i thought "no problem,
i know how to do that, ill do it"
i had not expected this to be controversal

> about your "monowhite switching patch". Furthermore, to me it's
> highly unncecessary to use monowhite whatsoever. The space savings
> are quite irrelevant nowadays, and the logic to detect whether a
> file is black & white only creates more noise in the code. Here's a
> patch that restores the old behaviour of only using pal8 for 1 bpp
> video, and removes superfluous monowhite stuff.

basically 100% of avis with monowhite are black&white, we do not have
a single (no craftet) sample that contains paletted monochrome data
in avi.
IMHO its bizare to convert black and white 1 bpp data in the decoder
to 8bit paletted data
we reject colorspace/pixel format converting in the decoder normally
unless its somehow a mess otherwise.

and its a problem to for using the output because an encoder has to
deal and encode 8bit paletted data from such avis even though they
really are just black and white if pal8 is used


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160131/449d6374/attachment.sig>

More information about the ffmpeg-devel mailing list