[FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

Mats Peterson matsp888 at yahoo.com
Sun Jan 31 23:07:38 CET 2016


On 01/31/2016 10:53 PM, Mats Peterson wrote:
> Just because we have monow and monob pixel formats, it doesn't mean they
> should be used wherever 1 bpp data is involved. And once again, the
> semantics according to Microsoft are that 1 bpp AVI is NEVER monochrome,
> it is ALWAYS palettized, regardless of the number of colors, or whether
> they are black & white or not. And implementing "mono switches" for 1
> bpp depth for every file format involves writing a lot of superfluous
> code just for this, and in the case of qtrle, creating a whole new loop
> for the 1 bpp case. Overkill.
>
> Mats

You don't seem to realize the simplicity of having a uniform way of 
converting 1, 2, 4, and 8 bpp palettized video data. Why should using 
monow even be considered? Less space? Not a valid argument nowadays. 
There are no reasons to use it really, except for the case of TIFF with 
its bilevel mode, which only uses black & white.

Mats



More information about the ffmpeg-devel mailing list