[FFmpeg-devel] [PATCH] avfilter: Add max stats to PSNR log

Michael Niedermayer michael at niedermayer.cc
Fri Jul 22 21:20:22 EEST 2016


On Thu, Jul 21, 2016 at 03:58:30PM -0700, Lucas Cooper wrote:
> > Also that different information should possibly be optional
> > as in version 2 format, and with that the first line could specify
> > the version of the format
> 
> Given that this would be a backwards incompatible change (anything assuming
> every line is a stat line would break on the header), should I take
> "optional" here to mean "controlled by a flag"?
> 

> How about I add:
> - A 'stats_version' option, integer, defaults to '1', which outputs the
> existing format as is, without a version header.
> - A second version '2', which outputs a version header, perhaps a list of
> included fields?
> - A 'log_raw' flag, which, when enabled, adds the raw error and max numbers
> for each channel and averaged over all channels, from which MSE and PSNR
> can be calculated.

ok

if possible, please split this in multiple self contained patches
it sounds like this is has become more than one feature


thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160722/241af3d2/attachment.sig>


More information about the ffmpeg-devel mailing list