[FFmpeg-devel] [PATCH] tools: update normalize script example to use loudnorm

Hendrik Leppkes h.leppkes at gmail.com
Wed Jun 15 16:45:51 CEST 2016


On Wed, Jun 15, 2016 at 4:40 PM, Kyle Swanson <k at ylo.ph> wrote:
> On Mon, Jun 13, 2016 at 3:23 AM, Clément Bœsch <u at pkh.me> wrote:
>> On Sun, Jun 12, 2016 at 10:44:15PM -0500, Kyle Swanson wrote:
>>> Signed-off-by: Kyle Swanson <k at ylo.ph>
>>> ---
>>>  tools/normalize.py | 33 ------------------------------
>>>  tools/normalize.rb | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 60 insertions(+), 33 deletions(-)
>>>  delete mode 100755 tools/normalize.py
>>>  create mode 100644 tools/normalize.rb
>>>
>>
>> Please de not delete normalize.py
>
> We have a filter that does this now, if we're distributing a loudness
> normalization script it should be using the loudnorm filter.
>

One key point, changing the script to use another filter is one thing,
entirely changing the language its written in .. maybe not quite as
expected of a change.
If anything the syntax of the script should remain the same and it
should do the same (and require the same interpreter), if it
internally does something else, thats fine by me. Unless ubitux
prefers the old one for testing purposes to keep existing.

- Hendrik


More information about the ffmpeg-devel mailing list