[FFmpeg-devel] [PATCH] lavf/img2dec: add pnm pipe demuxers

[Carl Eugen Hoyos]

Clément Bœsch <u <at> pkh.me> writes:

> On Mon, Jun 20, 2016 at 01:07:09PM +0000, Carl Eugen Hoyos wrote:
> > Clément Bœsch <u <at> pkh.me> writes:
> > 
> > > +static int pgmyuv_probe(AVProbeData *p)
> > > +{
> > > +    int ret = pgmx_probe(p);
> > > +    return ret && av_match_ext(p->filename, "pgmyuv") ? ret : 0;
> > 
> > You could add a comment that this format was invented within 
> > FFmpeg, I hadn't realized this.
> 
> I'm not sure the probe code is really the best place to do 
> that but added locally anyway

Thank you!
I was a little surprised why the extension is used to distinguish.

> > And you could check for positive resolutions if you want to 
> > improve probing.
> 
> Yeah, probing could be improved, but it requires some line 
> skipping logic (empty lines, comments, etc) I wasn't that 
> motivated to write (probably due to a traumatic history with 
> text subtitles).

Then please ignore;-)

> > Did you run the probe test for the new functions?
> 
> Should I pass special parameters?

You don't have to (the test passed), if you add the name 
of the demuxer you want to test, it runs faster.

Thank you, Carl Eugen