[FFmpeg-devel] [PATCH] configure: remove -std= from c++ compilation

Michael Niedermayer michael at niedermayer.cc
Mon Jun 27 21:32:20 CEST 2016


On Sun, Jun 26, 2016 at 07:08:06PM -0400, Rick Kern wrote:
> Pulling -std=c99 into CXXFLAGS from CFLAGS causes a compile error with c++
> files using clang on OS X.
> Adding -std=c++98 unconditionally to CXXFLAGS will generate a compile error
> on compilers that don't support the -std option.
> It works but is less readable if -std=c++98 is appended after -std=c99 when
> the -std option is supported.
> 
> Signed-off-by: Rick Kern <kernrj at gmail.com>
> ---
>  common.mak | 2 +-
>  configure  | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160627/75a5aaec/attachment.sig>


More information about the ffmpeg-devel mailing list