[FFmpeg-devel] [PATCH] avfilter/drawutils: change to support native endian only

Muhammad Faiz mfcc64 at gmail.com
Tue Jun 28 11:07:31 CEST 2016


On Mon, Jun 27, 2016 at 6:02 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Mon, Jun 27, 2016 at 04:46:16PM +0700, Muhammad Faiz wrote:
>> previously support little endian only because of fate problem
>> generally native endian code is faster
>>
>> require 'tests/fate-run: support both le/be formats on pixfmts'
>> need someone tests it on BE machine
>>
>> Signed-off-by: Muhammad Faiz <mfcc64 at gmail.com>
>> ---
>>  libavfilter/drawutils.c | 43 ++++++++++++++++----------
>>  libavfilter/vf_lut.c    | 81 +++++++++++++++++++++----------------------------
>>  2 files changed, 62 insertions(+), 62 deletions(-)
>
> breaks fate on big endian (mips)
>
> Test filter-pixfmts-pad failed. Look at tests/data/fate/filter-pixfmts-pad.err for details.
> make: *** [fate-filter-pixfmts-pad] Error 1
> make: *** Waiting for unfinished jobs....
> --- tests/ref/fate/filter-pixfmts-lut   2016-06-26 18:25:32.960458744 +0200
> +++ tests/data/fate/filter-pixfmts-lut  2016-06-27 12:48:19.049852682 +0200
> @@ -3,38 +3,38 @@
>  bgr24               fa43e3b2abfde8d9e60e157a9acc553d
>  bgra                4e2e689897ee7a8e42b16234597bab35
>  rgb24               a356171207723a580e7d277078072005
> -rgb48le             5c7dd8575836d18c91e09f1915cf9aa9
> +rgb48be             d9a7669cab9159c7f28dc92387fab304
>  rgba                7bc854c2698b78af3e9159a19c2d9d21
> -rgba64le            3a087ecab583d1930220592731f282b4
> +rgba64be            612546f91b274bcc8c314386ba410c3d
>  yuv410p             51b39a0e33f108e652457a26667319ea
>  yuv411p             9204c5af92aef4922a05f58c1f6c095e
>  yuv420p             7c43bb0cae8dee633375c89295598508
> -yuv420p10le         1352712dd31cce78bd5441294004cf85
> -yuv420p12le         c66f82da9fda458ba3abda057c58e591
> -yuv420p14le         e45cb5e2a75bf6143da0b55004767f78
> -yuv420p16le         eff54782c51770edfd6b84c958ac7120
> -yuv420p9le          4a6776b3379f12ad45caee8072a13695
> +yuv420p10be         4ef2f621258d77ef242e37e39b636f7c
> +yuv420p12be         bfb9f581c3749fd102f5bbd2065ad67a
> +yuv420p14be         999d29d713e52f61a5eea1765c57e660
> +yuv420p16be         a8ff20f5a96ba42fa5968bda64e160bd
> +yuv420p9be          862db8509f9cbaa7fd542851047a50fc
>  yuv422p             67df35da0c35e54882492b2365438254
> -yuv422p10le         0158371a800294015def7f0ef66c78ea
> -yuv422p12le         bc49d3863ffb89658a17bf8c4fe773b0
> -yuv422p14le         b55cb791d286b0b3391fe7481785e5b3
> -yuv422p16le         fc3b2ba889ffaf1633000fc774307c33
> -yuv422p9le          6e2a42ae36ed5e8b5112987639728af5
> +yuv422p10be         384f3f8757ecdcb87e0f5225f92ee244
> +yuv422p12be         b6bac207d387098f22b2f3613d668d30
> +yuv422p14be         48b83f5ecc7931cbab467801934bbf87
> +yuv422p16be         be0db4de9820408fd6770cdcea0535f9
> +yuv422p9be          f2486947acf0e98977cbec23c79871b3
>  yuv440p             5e41adcfc27be4369afd217b61b2ffe3
> -yuv440p10le         8b49714bba268fb4a79b5a84223ad17a
> -yuv440p12le         15ab4f453238bd9c13b18af81e22f060
> +yuv440p10be         cbcbbbdbe4a1dc041bee11b757be89d7
> +yuv440p12be         7603fda62bd9cb383e7d82af0bf5fefd
>  yuv444p             a2b58590aef88db2c1f14a1a3a3b0359
> -yuv444p10le         c076c20fc808f95b34adb88aca442f48
> -yuv444p12le         af8d4dd88169d5cffc2f3fce6333a94c
> -yuv444p14le         93367133e25d088d4535199ed1f1ed58
> -yuv444p16le         800940feec14365ccd9b4863e38f6991
> -yuv444p9le          c120044350852c4cd16a302dd1ceda79
> +yuv444p10be         a3481fe5e95190749f2ac3288ad686c3
> +yuv444p12be         118c1d1f8270cebec8554972adde05da
> +yuv444p14be         6671cff7f64e9f9bc1dceb3d31a69c00
> +yuv444p16be         27effaa1096361ffb6b69d1d0e8a35d6
> +yuv444p9be          dcd44e88c9424d5666ac950f4e3e19e4
>  yuva420p            518a380bf1af60ef2ecf4754eec088e9
> -yuva420p16le        72ad4fa535b007d122666ce103ef9c8b
> +yuva420p16be        aaa6db0ce07716dab15782dfbad5aca9
>  yuva422p            7110ac2e37377b05b6fc5ad967dfabb5
> -yuva422p16le        e2867210660ada5784a60b4339ac52c0
> +yuva422p16be        f5c06d197a1096314553b1d89f43d96f
>  yuva444p            642f3958f141dece9e99407945e2ef43
> -yuva444p16le        ab04ba8acbe38085b0df650d82065eb0
> +yuva444p16be        5337a7c64bd26a675d4a2bb8881e6fcb
>  yuvj420p            65bc88887c7f06a6221155ca7f9cfca4
>  yuvj422p            ff5baffefc8ffe4547653092fd7da200
>  yuvj440p            ef3f27270e60ac06582e3ac7c2f3e6fa

Did you apply 'tests/fate-run: support both le/be formats on pixfmts' first?

Thank's


More information about the ffmpeg-devel mailing list