[FFmpeg-devel] [PATCH] Use lowercase includes and library names for schannel check

Ismail Donmez ismail at i10z.com
Wed Mar 16 07:08:41 CET 2016


On Tue, Mar 15, 2016 at 9:51 PM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> On Tue, Mar 15, 2016 at 8:33 PM, Reimar Döffinger
> <Reimar.Doeffinger at gmx.de> wrote:
>> On Tue, Mar 15, 2016 at 07:32:35PM +0000, Derek Buitenhuis wrote:
>>> On 3/15/2016 7:26 PM, Reimar Döffinger wrote:
>>> > I see this:
>>> > libavformat/tls_schannel.c:#include <security.h>
>>> > libavformat/tls_securetransport.c:#include <Security/Security.h>
>>> >
>>> > Are those different headers?
>>>
>>> Consider that one is for OS X native TLS, and one is for
>>> Windows native TLS.
>>
>> I only did a grep and it wasn't exactly clear from that :)
>> But in that case we should go with the patch,
>> configure testing something else than the file uses
>> is a bug, even if it's only the case of the
>> header name that differs.
>
> Actually the library file is spelled Secur32.lib in the Windows SDK,
> and apparently all lower-case in mingw, but since Windows itself
> doesn't care, its fine with me to change this.

Thanks! Can someone please apply it?

Regards,
ismail


More information about the ffmpeg-devel mailing list