[FFmpeg-devel] [PATCH] Added a selftest to libavutil/display.c

Petru Rares Sincraian psincraian at outlook.com
Tue Mar 22 13:05:53 CET 2016


Hi,
In this patch I made the following changes:

 - Added the missing file /tests/ref/fate/display
 - Now the program prints integers to avoid different results on different platforms.


Thanks for your patience and especially to Michael,
Petru Rares.

________________________________________
From: Michael Niedermayer <michael at niedermayer.cc>
Sent: Sunday, March 20, 2016 11:32 PM
To: FFmpeg development discussions and patches
Cc: Petru Rares Sincraian
Subject: Re: [FFmpeg-devel] [PATCH] Added a selftest to libavutil/display.c

On Sun, Mar 20, 2016 at 09:29:04AM +0000, Petru Rares Sincraian wrote:
>
>     - Check if av_display_rotation_get() gets the correct degrees
>     - Check if av_display_rotation_set() sets the correct matrix
>     - Check if av_display_matrix_flip() changes correct the matrix
> ---
>  libavutil/Makefile       |  1 +
>  libavutil/display.c      | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  libavutil/display.h      |  1 +
>  tests/fate/libavutil.mak |  4 ++++
>  4 files changed, 53 insertions(+)

Missing reference file
make fate-display
...
TEST    display
reference file './tests/ref/fate/display' not found
./tests/fate-run.sh: 307: ./tests/fate-run.sh: cannot open tests/data/fate/display.diff: No such file
Test display failed. Look at tests/data/fate/display.err for details.
make: *** [fate-display] Error 1

also, if you arent subscribed to ffmpeg-devel, its highly recommanded
to subscribe as developers generally forget to CC people who are not
subscribed

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-a-selftest-to-libavutil-display.c.patch
Type: text/x-patch
Size: 4231 bytes
Desc: 0001-Added-a-selftest-to-libavutil-display.c.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160322/c276ec24/attachment.bin>


More information about the ffmpeg-devel mailing list