[FFmpeg-devel] [PATCH] lavc/ccaption_dec: remove usage of avctx->time_base

Michael Niedermayer michael at niedermayer.cc
Mon Mar 28 16:57:51 CEST 2016


On Mon, Mar 28, 2016 at 02:10:51PM +0200, Clément Bœsch wrote:
> lavc/utils already rescales avpkt->pts to sub->pts in AV_TIME_BASE_Q
> before calling the decode callback. This prevents from rescaling again
> into the decoder, and avoid the use of avctx->time_base which will
> disappear in the incoming codecpar merge.
> 
> This commit also replaces the use of "20 centisecond" (ass time base)
> with "200 ms".
> ---
>  libavcodec/ccaption_dec.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

with
./ffmpeg -f lavfi -i "movie=Starship_Troopers.vob[out0+subcc]"  -vn -map s out.srt

this causes a moderate change in the timings
is that intended ?

 6
-00:00:39,273 --> 00:00:41,783
+00:00:36,270 --> 00:00:41,776
 <font face="Monospace"><i>AH.
 ASSISTANT INSTRUCTOR.</i></font>

 7
-00:00:41,775 --> 00:00:44,775
+00:00:36,270 --> 00:00:44,779
 <font face="Monospace">SHOULD I CALL YOU
 "SIR" ?</font>

 8
-00:00:44,778 --> 00:00:47,278
+00:00:36,270 --> 00:00:47,281
 <font face="Monospace">ONLY WHEN I GIVE YOU
 AN ORDER.</font>

 9
-00:00:47,281 --> 00:00:49,281
+00:00:36,270 --> 00:00:49,283
 <font face="Monospace">PREPARE FOR DEPARTURE.</font>


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160328/613d0ab4/attachment.sig>


More information about the ffmpeg-devel mailing list